Skip to content

[Merged by Bors] - chore(Analysis/InnerProductSpace): remove misleading comment - #42123

Closed
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:adjointnoncomputable
Closed

[Merged by Bors] - chore(Analysis/InnerProductSpace): remove misleading comment#42123
felixpernegger wants to merge 1 commit into
leanprover-community:masterfrom
felixpernegger:adjointnoncomputable

Conversation

@felixpernegger

@felixpernegger felixpernegger commented Jul 27, 2026 •
edited by grunweg
Loading

Copy link
Copy Markdown
Contributor

The comment makes no sense any more: noncomputable section checks first if a def is computable, and only if not, makes it noncomputable. So noncomputable section wouldn't make a difference here (for an example where noncomputable def vs noncomputable section makes a difference see #mathlib4 > noncomputable section @ 💬).

Looking at the git history, it used to be marked noncomputable def, but that was removed in #40091 without comment. This is not a performance issue any more, so the comment can just be removed.

(I stumbled about this while reviewing #42122)

Open in Gitpod

@felixpernegger felixpernegger changed the title chore: remove misleading comment chore(Analysis/InnerProductSpace): remove misleading comment Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown

PR summary d287a74723

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

✅ Lean-aware diff — post-build, computed from the Lean environment (commit d287a74).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.

No changes to strong technical debt.

No changes to weak technical debt.

Current commit d287a74723
Reference commit 7779d601f7

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Jul 27, 2026
@mcdoll

mcdoll commented Jul 27, 2026

Copy link
Copy Markdown
Member

LGTM, thanks!
maintainer merge

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by mcdoll.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 27, 2026
@grunweg

grunweg commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I tweaked the PR description quite a bit - LGTM now. Thanks!
bors merge

@mathlib-triage mathlib-triage Bot removed the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jul 27, 2026
@felixpernegger

felixpernegger commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@grunweg bors bugged

@grunweg

grunweg commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Jul 27, 2026
@felixpernegger
chore(Analysis/InnerProductSpace): remove misleading comment (#42123)
6f1c645 
The comment makes no sense any more: `noncomputable section` checks first if a def is computable, and only if not, makes it noncomputable. So `noncomputable section` wouldn't make a difference here (for an example where `noncomputable def` vs `noncomputable section` makes a difference see [#mathlib4 > noncomputable section @ 💬](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/noncomputable.20section/near/609434583)).

Looking at the git history, it used to be marked `noncomputable def`, but that was removed in #40091 without comment. This is not a performance issue any more, so the comment can just be removed.

Co-authored-by: Batixx <s59fpern@uni-bonn.de>
@mathlib-bors mathlib-bors Bot added the bors-staging This PR is currently being built by bors on the staging branch. label Jul 27, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Analysis/InnerProductSpace): remove misleading comment [Merged by Bors] - chore(Analysis/InnerProductSpace): remove misleading comment Jul 27, 2026
@mathlib-bors mathlib-bors Bot closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bors-staging This PR is currently being built by bors on the staging branch. ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixpernegger @mcdoll @grunweg